chore: update claude model selector#2742
Merged
Merged
Conversation
Contributor
Greptile SummaryUpdates the Claude model selector to add three newer models (
Confidence Score: 5/5Safe to merge — all changes are model ID string updates with no logic modifications. The diff is a mechanical rename of model identifiers across the plugin registry, test fixtures, and Storybook stories. All three new model IDs (claude-fable-5, claude-opus-4-8, claude-sonnet-5) are confirmed valid Anthropic API identifiers. The only loose end is a stale anthropic/claude-sonnet-4-5 string in pty-env.test.ts that belongs to a different agent and was not touched by this PR. No files require special attention. The single comment on pty-env.test.ts is a non-blocking housekeeping note about an unrelated agent's test fixture.
|
| Filename | Overview |
|---|---|
| packages/plugins/src/agents/impl/claude/index.ts | Adds claude-fable-5 and replaces claude-opus-4-5/claude-sonnet-4-5 with claude-opus-4-8/claude-sonnet-5; claude-haiku-4-5 remains unchanged. |
| apps/emdash-desktop/src/shared/core/conversations/conversation-config.ts | Updates JSDoc example model name from claude-sonnet-4-5 to claude-sonnet-5; no logic changes. |
| apps/emdash-desktop/src/shared/core/conversations/conversation-config.test.ts | Updates test fixtures to use new model IDs (claude-sonnet-5, claude-opus-4-8); all test cases updated consistently. |
| packages/ui/src/react/components/chat-composer/chat-composer.stories.tsx | Updates Storybook mock model data; adds claude-fable-5 entry and renames existing models to new IDs. |
| packages/ui/src/react/components/combobox-popover/combobox-popover.stories.tsx | Updates Storybook MODELS array and default state values to use new model IDs including the new claude-fable-5 entry. |
| packages/ui/src/react/examples/chat-panel.stories.tsx | Updates MOCK_MODELS and default selected model to match new model IDs; mirrors changes in chat-composer stories. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Claude Plugin Model Registry] --> B[claude-fable-5\nIntelligence: 4, Speed: 3\n🆕 Added]
A --> C[claude-opus-4-8\nIntelligence: 5, Speed: 2\n🔄 was claude-opus-4-5]
A --> D[claude-sonnet-5\nIntelligence: 4, Speed: 4\n🔄 was claude-sonnet-4-5]
A --> E[claude-haiku-4-5\nIntelligence: 3, Speed: 5\n✅ Unchanged]
F[conversation-config.ts] -- JSDoc example updated --> D
G[conversation-config.test.ts] -- Test fixtures updated --> C
G -- Test fixtures updated --> D
H[UI Stories] -- Mock data updated --> B
H -- Mock data updated --> C
H -- Mock data updated --> D
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Claude Plugin Model Registry] --> B[claude-fable-5\nIntelligence: 4, Speed: 3\n🆕 Added]
A --> C[claude-opus-4-8\nIntelligence: 5, Speed: 2\n🔄 was claude-opus-4-5]
A --> D[claude-sonnet-5\nIntelligence: 4, Speed: 4\n🔄 was claude-sonnet-4-5]
A --> E[claude-haiku-4-5\nIntelligence: 3, Speed: 5\n✅ Unchanged]
F[conversation-config.ts] -- JSDoc example updated --> D
G[conversation-config.test.ts] -- Test fixtures updated --> C
G -- Test fixtures updated --> D
H[UI Stories] -- Mock data updated --> B
H -- Mock data updated --> C
H -- Mock data updated --> D
Reviews (1): Last reviewed commit: "chore(ui): revert story model updates" | Re-trigger Greptile
arnestrickmann
approved these changes
Jul 2, 2026
arnestrickmann
left a comment
arnestrickmann
left a comment
Contributor
There was a problem hiding this comment.
thanks for updating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshot/Recording (if applicable)
https://cap.link/rc2ntesdzbhaa0f
Checklist
messages and, when possible, the PR title